Skip to content

London | 26-ITP-Jan | Alex Okorefe | Sprint 2 | Form controls#1128

Open
Alex-Os-Dev-Lab wants to merge 5 commits intoCodeYourFuture:mainfrom
Alex-Os-Dev-Lab:feature/form-control
Open

London | 26-ITP-Jan | Alex Okorefe | Sprint 2 | Form controls#1128
Alex-Os-Dev-Lab wants to merge 5 commits intoCodeYourFuture:mainfrom
Alex-Os-Dev-Lab:feature/form-control

Conversation

@Alex-Os-Dev-Lab
Copy link

@Alex-Os-Dev-Lab Alex-Os-Dev-Lab commented Feb 3, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added customer name and validation to index.html
  • Email validation and notes added to index.html
  • Included t-shirt selection options to form
  • Updated customer instructions for required fields
  • Refactored spacing between customer name and email inputs using Devtools; to improve lighthouse accessibility score

Questions

I have no questions at the moment.

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6866b17
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698243278c700e0007770e8b
😎 Deploy Preview https://deploy-preview-1128--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Alex-Os-Dev-Lab Alex-Os-Dev-Lab added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Feb 3, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@github-actions

This comment has been minimized.

@Alex-Os-Dev-Lab Alex-Os-Dev-Lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework and removed 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. NotCoursework labels Feb 3, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@github-actions

This comment has been minimized.

@Alex-Os-Dev-Lab Alex-Os-Dev-Lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 6, 2026
</div>
<br>

</section>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, notice when this tag is opened, and where it closes (note how tags are nested)


</div>

<!-- T-Shirt Size Selection:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment indentation is inconsistent with the div tag it comments

<fieldset>
<legend>*T-Shirt Colour:</legend>
<label for="ColourRed">Red</label>
<input type="radio" id="ColourRed" name="T-ShirtColourSelection" value="Red" required>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically radio button is placed to the left from the text it refers to

<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<!--

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment indentation is inconsistent with the div below

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants